RabbitMQ: Specify how to populate messaging.destination.name
#1531
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Good point, I didn't consider it but maybe it makes sense 🤔 |
| `messaging.destination.name` SHOULD be set to: | ||
|
|
||
| - **Producers**: `{exchange}:{routing key}` when both values are present and non-empty. | ||
| Otherwise: `amq.default` when the default exchange is used and no routing key is provided |
There was a problem hiding this comment.
can there be an {exchange} but not a {routing key}, or can there be a {routing key} but not a {exchange}? it may be helpful to be explicit about fallback options (if any), in particular, do you drop the : or not when only one of them is present, here's an example where we cover these fallbacks: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-spans.md#name
There was a problem hiding this comment.
Yeah they can be empty like that AFAIK. I adapted it a bit, hopefully it is clearer now.
Fixes #1529
Changes
Specify in more detail how to populate
messaging.destination.namefor RabbitMQ. I based it on the Default exchange docs. My understanding is that arouting keyis always present, even when using the default exchange (empty in this case). The routing key then is the queue name.For all other cases, I left it as
amq.defaultwhich is what RabbitMQ uses. I saw reference for it for example here: https://www.rabbitmq.com/docs/access-controlMerge requirement checklist
[chore]